Description: CONTENTS 1. Changed the plastik theme to draw a lighter line as listview branch. 2. Rounded selection in iconview (konqueror/kdesktop)* 3. A modern looking rubberband (gnome/xp semi-transparent style).* 4. Modified dialogs when in iconlist mode to highlight item on mouse over (mozilla-firefox). 5. Added a new konqueror sidebar look. Idea from http://www.kde-look.org/content/show.php?content=17049 6. Now sidebar is saved per profile (bug 58580) 7. Fixed bug 88964 (Highlighting of files in Detailed List View does not correspond to the area of activation).
Obs.: All patches are tested in kde-3.3.1/qt-x11-free-3.3.3 official sources. I can't garantee that they will work in other kde versions.
* some patches are modified versions from the patches found in http://lists.kde.org/?l=kde-core-devel&m=107624741505943&w=2
GOOD NEWS I started a thread in kde-devel mailing list to discuss the insertion of the patches in next kde release. See http://lists.kde.org/?l=kde-devel&m=109863377620287&w=2 Some of the improvements are already in KDE CVS. I contacted trolltech and they are analyzing the patches.
TIPS - To improve the performance of the rubberband try to enable the option "RenderAccel" in your XF86Config file. (sinve version 0.5.2 the rubberband performance is improved) - To enable the new konqueror sidebar look add the line "SidebarStyle=1" in the file $HOME/.kde/share/config/konqsidebartng.rc in the group that has the same name of the profile you want to change: For example: [webbrowsing] SidebarStyle=1
If anyone has more ideas (original ideas) to add to this patches, tell me and perhaps i will try to implement them.Last changelog:
v1.0.0: (2004-Nov-2 * fixed bug with rubberband in iconview mode. * added install instructions.
v0.5.5: (2004-Oct-31) * fixed bug when new rubberband effect is disabled.
v0.5.4: (2004-Oct-31) * added rubberband color cache (improve rubberband performance a little more). I can't do incremental patch cause i'm using the KDE CVS version now. The only file that was modified is kdelibs/kdefx/kstyle.cpp
v0.5.3: (2004-Oct-31) * improved rubberband performance in iconview (now only the modified area is draw). * fixed bug when drawing rubberband and right mouse button is clicked. * added incremental patch. For those who are using version 0.5.2 just apply the patches found in dir patches-0.5.2. Note: Only use the patches found in dir patches-0.5.3 if you are using version 0.5.2. Any doubt how to use this mail me. * added TODO file. If you found any bug not in TODO mail me, and i will try to fix.
v0.5.2: (2004-Oct-26) * fixed error in drawing the item background in konqueror detailed view mode when that is a background image set. You just need to recompile kdebase/konqueror/listview.
v0.5.1: (2004-Oct-26) * fixed compile error in kdebase/konqueror/listview.
v0.5.0: (2004-Oct-25) * a lot of cleanup and refactoring. * fix bug in konqueror detailed view mode that made the alternate background lines draw incorrect (thanks to DarkLord to point this out). * now no app will be affected by the patch for bug 88964. * modified qt patches to kde ones so is more easy to get they accepted by kde developers. * removed kdepim patch (no more necessary).
I did tried this patch and was forced to leave it since gives a bad behaviour when using detailed list view in konqueror.
Selecting files stays with an erratic behaviour.
why aren't your patch include in KDE?
some of the modification are actual bug fix. they really should made it to KDE.
look, design improvement could be a different style/decoration that can be downloaded separately. or a smaller patch that adds options to current style/windeco.
thanks
Judging from the screenshot, the changes for rounded selections in your patchset are the same as those shipped by Ubuntu, no?
They have jagged edges. I've attached the patch for anti-aliased rounded selections to the bug report/wishlist (I was going to create one earlier but wasn't sure if one already existed).
They are also available here:
http://trisk.acm.jhu.edu/kde/
Also, re: comments on speed/stability: I've not looked at the patchset, but presumably the rubberband changes are the same ones in the Ubuntu packages, and they are stable in practice, and fast where the Render extension for X is accelerated. If it produces crashes you probably miscompiled KDE.
I applied that patches, but my rubber band square was not filled. The round selection works for more than one icon (if I click in one icon it's was not round-selected).
http://img527.imageshack.us/img527/8448/temp6ue1.jpg
not that i don't like your improvement because it makes KDE looks more like XP but I wouldn't use it for other reason. It makes KDE at least 2 times slower. The mass-selection of files with the mouse cursor is slow as hell. Applications crash and I see unexpected behaivours...
So knowing the future of KDE, seeing KDE 4 screenshots, sorry to say but this is useless...honestly, no offence
how does the performance of the rubberband compare to the performance of the band in gnome. the gnome one had no performanceproblems at all for me, using fglrx driver though...
If it's slower, looking into how the gnome one works could perhaps optimize it a little.
The improvements that you made are realy great. It would be a great idea to submit them to the official kde release so that everyone will be able to use these impovements without having to patch their kde.
Normally, when I try to drag a file into a folder, the folder will have a little outline around it indicating that it will accept the drop event.
When I apply this patch however, I lose the outline feedback during drag-n-drop in Icon View mode.
Some testing seems to indicate that this is because the patch guts the contents of paintFocus() in qiconview.cpp. Any idea why that code was removed? Restoring it makes this bug go away, but I would like to think there must have been some reason it was removed in the first place....
Thanks!
Lipstik is better looking than plasktik. Could you please add these patches for Liptik and KDE 3.4.
KDE 3.4 is definitely better than 3.3, and your patches can make it the BEST!!! :)
Thank you.
The only other thing that drives me crazy about KDE and Gnome -- hell even windows -- is that when I download something it takes me a little longer than I like to find the downloaded file that should have been placed on my desktop. It would be awsome if files that were recently downloaded within a given period of time were highlighted. So I would instantly see a highlighted file on my desktop. Or if I open my home directory in konqueror I could easily see the file I just downloaded.
Great idea, how about making it that it displays changed files with a highlight.. Not timed but till you view the folder containing the file or use the file on your desktop.
Is there any way that you could do a "Select Hand-Drawn Region"? -- Much like the select option in Gimp. I think this would be a great addition because I am constantly moving my icons into groups so I can select them all. It would be nice if you could just draw a "blob" that defined the exact area to select. Does this option exist?
oki, here we have a trully great idea!
if possible, implement this, it would make huge changes to how users will select their items (and it will make the selections more natural as well)
Finally a good looking linux GUI Desktop, its been years in the making but its almost there. Lets hope that these improvements/themes/icons make it into the next KDE release.
Finally we can retire the previous and current KDE themes into the Ugliest Interfaces Hall of Shame.
Now if we can only get rid of the retards who come up with the Names of KDE Applications and linux might have a chance to get some market penetration.
Ratings & Comments
313 Comments
I did tried this patch and was forced to leave it since gives a bad behaviour when using detailed list view in konqueror. Selecting files stays with an erratic behaviour.
why aren't your patch include in KDE? some of the modification are actual bug fix. they really should made it to KDE. look, design improvement could be a different style/decoration that can be downloaded separately. or a smaller patch that adds options to current style/windeco. thanks
Judging from the screenshot, the changes for rounded selections in your patchset are the same as those shipped by Ubuntu, no? They have jagged edges. I've attached the patch for anti-aliased rounded selections to the bug report/wishlist (I was going to create one earlier but wasn't sure if one already existed). They are also available here: http://trisk.acm.jhu.edu/kde/ Also, re: comments on speed/stability: I've not looked at the patchset, but presumably the rubberband changes are the same ones in the Ubuntu packages, and they are stable in practice, and fast where the Render extension for X is accelerated. If it produces crashes you probably miscompiled KDE.
I applied that patches, but my rubber band square was not filled. The round selection works for more than one icon (if I click in one icon it's was not round-selected). http://img527.imageshack.us/img527/8448/temp6ue1.jpg
not that i don't like your improvement because it makes KDE looks more like XP but I wouldn't use it for other reason. It makes KDE at least 2 times slower. The mass-selection of files with the mouse cursor is slow as hell. Applications crash and I see unexpected behaivours... So knowing the future of KDE, seeing KDE 4 screenshots, sorry to say but this is useless...honestly, no offence
http://beta.smileaf.org/files/patches/ImprovingKDE-1.0.0-r2.tar.bz2 Here is an updated patch set for KDE 3.5.0 and Qt 3.3.4
I just added a wish for rounded corners on the bugs.kde.org page, but I need help voting it up! check out: http://bugs.kde.org/show_bug.cgi?id=114692 also check out this one for new rubberband: http://bugs.kde.org/show_bug.cgi?id=90051 and this one for much better usability in setting-windows: http://bugs.kde.org/show_bug.cgi?id=114690
I just posted this as a wish for rounded selection on bugs.kde.org Register an account and vote it up so developers will see it! http://bugs.kde.org/show_bug.cgi?id=114692 also vote on this one (rubberband): http://bugs.kde.org/show_bug.cgi?id=90051 and a great feature for improving usability: http://bugs.kde.org/show_bug.cgi?id=114690
how does the performance of the rubberband compare to the performance of the band in gnome. the gnome one had no performanceproblems at all for me, using fglrx driver though... If it's slower, looking into how the gnome one works could perhaps optimize it a little.
The improvements that you made are realy great. It would be a great idea to submit them to the official kde release so that everyone will be able to use these impovements without having to patch their kde.
is compatible with kde 3.4?? on a suse 9.3?? I ask this because I don't know if kde 3.4 already bring some of this patches.
Normally, when I try to drag a file into a folder, the folder will have a little outline around it indicating that it will accept the drop event. When I apply this patch however, I lose the outline feedback during drag-n-drop in Icon View mode. Some testing seems to indicate that this is because the patch guts the contents of paintFocus() in qiconview.cpp. Any idea why that code was removed? Restoring it makes this bug go away, but I would like to think there must have been some reason it was removed in the first place.... Thanks!
The location for both Ebuilds give a 404.
How is the integration of these patches with KDE SVN going?
Lipstik is better looking than plasktik. Could you please add these patches for Liptik and KDE 3.4. KDE 3.4 is definitely better than 3.3, and your patches can make it the BEST!!! :) Thank you.
Why is that not part of kde3.4 (at least for optional usage)? Hmmm...
nevertheless I'm a kde-addict! ;)
please put the gentoo 3.4 ebuilds also...
The only other thing that drives me crazy about KDE and Gnome -- hell even windows -- is that when I download something it takes me a little longer than I like to find the downloaded file that should have been placed on my desktop. It would be awsome if files that were recently downloaded within a given period of time were highlighted. So I would instantly see a highlighted file on my desktop. Or if I open my home directory in konqueror I could easily see the file I just downloaded.
Great idea, how about making it that it displays changed files with a highlight.. Not timed but till you view the folder containing the file or use the file on your desktop.
Is there any way that you could do a "Select Hand-Drawn Region"? -- Much like the select option in Gimp. I think this would be a great addition because I am constantly moving my icons into groups so I can select them all. It would be nice if you could just draw a "blob" that defined the exact area to select. Does this option exist?
oki, here we have a trully great idea! if possible, implement this, it would make huge changes to how users will select their items (and it will make the selections more natural as well)
Finally a good looking linux GUI Desktop, its been years in the making but its almost there. Lets hope that these improvements/themes/icons make it into the next KDE release. Finally we can retire the previous and current KDE themes into the Ugliest Interfaces Hall of Shame. Now if we can only get rid of the retards who come up with the Names of KDE Applications and linux might have a chance to get some market penetration.
Why the KDE 3.4 hase not this improvment :> . This is sad, becouse Yours work i so beautiful.
[root@localhost qt-x11-free-3.3.4]# patch -p0 < qt-x11-free-3.3.3.diff patching file src/iconview/qiconview.cpp Hunk #5 succeeded at 2785 (offset 2 lines). Hunk #7 succeeded at 3287 (offset 2 lines). Hunk #9 succeeded at 3328 (offset 2 lines). Hunk #11 succeeded at 3498 (offset 2 lines). Hunk #13 succeeded at 4599 (offset 2 lines). Hunk #14 succeeded at 5367 (offset 1 line). patching file src/widgets/qlistbox.cpp Hunk #1 succeeded at 2162 (offset 2 lines). Hunk #3 succeeded at 4379 (offset 2 lines). [root@localhost qt-x11-free-3.3.4]# How to patch good?
'Hunk' is good, only 'reject' is bad.